Welcome @kixa!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

/assign @gjtempleton

@gjtempleton Happy to bump the helm chart version if you want, but since this is pretty much a documentation change, I didn't think it would need it.

Hey, thanks for the PR, good catch.

As this is just a fix in an example I'm happy to bundle this in with another change ( #3954 ) and let the version bump in that take care of publishing a release to include both docs improvements.

EDIT: Famous last words, the failing Github action is blocking, so it won't be able to be merged without a version bump, unfortunately.

/lgtm
/approve

Thanks!
/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, Kixa

The full list of commands accepted by this bot can be found here.

The pull request process is described here